Skip to content

Fetch redirects based on the current URL. #11450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fetch redirects based on the current URL. #11450

wants to merge 1 commit into from
+6 −2

Conversation

@Ivorforce
Copy link
Member

@Ivorforce Ivorforce commented Nov 6, 2025 •
edited by mhilbrunner
Loading

This rewrites the URL fetch to use the current branch of the docs for redirects (e.g. /en/4.5) instead of latest for everything.

This will be needed in the future when redirects diverge. For now, we only use the js redirects on 4.5 and master, which haven't diverged much yet.

Warning

I can't fully test this locally, because serving with python doesn't seem to incorporate the 404 page correctly.
However, testing with the REPL in the browser, this should work correctly (even for local testing, if someone gets it to work fully).

Bugsquad edit: Followup to #11304

@Ivorforce Ivorforce requested a review from Calinou November 6, 2025 22:22
@Ivorforce Ivorforce added enhancement content:redirect Issues and PRs involving moving content and adding a redirect rule on the backend cherrypick:4.5 labels Nov 6, 2025
@Calinou
Copy link
Member

Calinou commented Nov 6, 2025 •
edited
Loading

I can't fully test this locally, because serving with python doesn't seem to incorporate the 404 page correctly.

I use https://github.com/TheWaWaR/simple-http-server with the following options while in _build/html:

--try-file 404.html

Python's SimpleHTTPServer also supports serving a custom 404 page, but it's more involved as you can't just use a CLI argument to enable it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhilbrunner mhilbrunner mhilbrunner approved these changes

@Calinou Calinou Awaiting requested review from Calinou

Assignees

No one assigned

Labels

cherrypick:4.5 content:redirect Issues and PRs involving moving content and adding a redirect rule on the backend enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Ivorforce @Calinou @mhilbrunner